Page MenuHomePhabricator

Flow: "Newest topics v" sort menu toggle is active and clickable before its menu works
Closed, ResolvedPublic

Description

missing sort menu, note vertical border to right of sort menu toggle

Browser tests sometimes fail on test2wiki, e.g.
https://integration.wikimedia.org/ci/view/BrowserTests/view/Echo+Flow/job/browsertests-Flow-test2.wikipedia.org-linux-firefox-sauce/280/testReport/junit/%28root%29/Sorting%20topics/Switch_topic_sorting_to_Recently_Active_Topics/

When I click Newest topics link
  And I click Recently active topics choice

timed out after 5 seconds, waiting for {:href=>/topiclist_sortby=updated/, :tag_name=>"a"} to become present (Watir::Wait::TimeoutError)

If you watch the movie (you'll laugh, you'll cry) or the screen shots, you see the "Newest topics v" menu toggle goes dark on hover/click[1] and a vertical border appears to its right, but its menu does not appear. I think this is a timing issue: you can reproduce by visiting a Flow board in a new private Firefox session and as soon as you see Newest topics, click it. Nothing appears except for the vertical border. When the menu fails to appear it will not appear on subsequent clicks, no matter how long you wait (until you reload the page).

The "Newest topics v" menu toggle should be invisible or disabled until its menu is functional. See also bug 72339 "Flow: sort menu broken in non-JavaScript".

[1] There's a UX inconsistency: mediawiki.ui buttons go _light_ on hover and only darken on click, this menu toggle that requires a click does not.


Version: master
Severity: normal

Attached:

2014-11-18_Flow_no_sort_menu.png (876×1 px, 140 KB)

Details

Reference
bz73597

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:53 AM
bzimport set Reference to bz73597.
bzimport added a subscriber: Unknown Object (MLST).
Spage triaged this task as Medium priority.Dec 16 2014, 10:25 AM

Priority is more than Low since it can break browser tests and is likely to happen on a slow connection.

This should work now. It only appears when it's ready.

Restricted Application added a subscriber: Aklapper. · View Herald Transcript