Page MenuHomePhabricator

Update less to new php version
Closed, InvalidPublic

Description

Hi please upgrade less to this http://lessphp.gpeasy.com/http://lessphp.gpeasy.com/ it is more frequent updated and does the same thing they also have a documentation on moving away from https://git.wikimedia.org/blob/mediawiki%2Fcore.git/71b56ffff4fbef2360ff02ed8a0fd1ee61585fd8/includes%2Flibs%2Flessc.inc.php


Version: unspecified
Severity: enhancement

Details

Reference
bz73614

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:54 AM
bzimport set Reference to bz73614.
bzimport added a subscriber: Unknown Object (MLST).

Where exactly does the current less version create a problem?

It doesent but does not seem to be maintaned as frequent as the other one is.

We're on 0.4.0 and release is now 1.7.0.2, so might not be a simple upgrade. There's certainly a lot of refactoring, as it's now not in one file. So switching to composer probably is a good idea here...

(In reply to Sam Reed (reedy) from comment #4)

We're on 0.4.0 and release is now 1.7.0.2, so might not be a simple upgrade.
There's certainly a lot of refactoring, as it's now not in one file. So
switching to composer probably is a good idea here...

Those are different libraries. We're using leafo/lessphp v0.4.0-alpha from Git master. Ori and I have commit access there. Afaik we're up to date.

http://leafo.net/lessphp/

Paladox is confused with an unrelated library that has a higher version number (relative to itself, it is by no means an indication that it's newer better, just like Chrome 30 and Firefox 29 can't be compared by their version number).

Namely, oyejorge/less.php v1.7.0.2, http://lessphp.gpeasy.com/. less.php is widely discarded due to its performance problems. In its current state it would never scale for what MediaWiki needs and there's no reason at the moment to switch to a completely different reason. There are no known issues affecting us and unlike Paladox's other commits (which upgrade a library to a newer version) this is not even that. They're two different libraries, existing independently, one of which happens to have a higher version number.