Page MenuHomePhabricator

SyntaxHighlight extension version undefined if accessed outside Special:Version
Closed, ResolvedPublic

Description

Hi there seems to be a problem with api for syntaxhighlight the problem is that the api does not detect the version. Please visit https://en.wikipedia.org/w/api.php?action=query&meta=siteinfo&siprop=extensions and scroll down to SyntaxHighlight.

It says this

 {
    "type": "parserhook",
    "name": "SyntaxHighlight",
    "descriptionmsg": "syntaxhighlight-desc",
    "author": "Brion Vibber, Tim Starling, Rob Church, Niklas Laxstr\u00f6m",
    "url": "https://www.mediawiki.org/wiki/Extension:SyntaxHighlight_GeSHi",
    "vcs-system": "git",
    "vcs-version": "88fc1cbb8cd7ab2c87da6d105a2e05a62937d889",
    "vcs-url": "https://git.wikimedia.org/tree/mediawiki%2Fextensions%2FSyntaxHighlight_GeSHi.git/88fc1cbb8cd7ab2c87da6d105a2e05a62937d889",
    "vcs-date": "2014-11-11T13:40:07Z",
    "license-name": "",
    "license": "/wiki/Special:Version/License/SyntaxHighlight"
},

expected results

{
    "type": "parserhook",
    "name": "SyntaxHighlight",
    "descriptionmsg": "syntaxhighlight-desc",
    "author": "Brion Vibber, Tim Starling, Rob Church, Niklas Laxstr\u00f6m",
    "url": "https://www.mediawiki.org/wiki/Extension:SyntaxHighlight_GeSHi",
    "version": "1.0.8.12",
    "vcs-system": "git",
    "vcs-version": "88fc1cbb8cd7ab2c87da6d105a2e05a62937d889",
    "vcs-url": "https://git.wikimedia.org/tree/mediawiki%2Fextensions%2FSyntaxHighlight_GeSHi.git/88fc1cbb8cd7ab2c87da6d105a2e05a62937d889",
    "vcs-date": "2014-11-11T13:40:07Z",
    "license-name": "",
    "license": "/wiki/Special:Version/License/SyntaxHighlight"
},

It says this on other wikis which download manualy and upload it without using git.

{
    "type": "parserhook",
    "name": "SyntaxHighlight",
    "descriptionmsg": "syntaxhighlight-desc",
    "author": "Brion Vibber, Tim Starling, Rob Church, Niklas Laxstr\u00f6m",
    "url": "https://www.mediawiki.org/wiki/Extension:SyntaxHighlight_GeSHi",
    "version": "GESHI_VERSION",
    "license-name": "",
    "license": "/index.php/Special:Version/License/SyntaxHighlight"
},

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:57 AM
bzimport added a project: SyntaxHighlight.
bzimport set Reference to bz73666.
bzimport added a subscriber: Unknown Object (MLST).

Change 174433 had a related patch set uploaded by Paladox:
Set Geshi version in main php file

https://gerrit.wikimedia.org/r/174433

Change 174433 had a related patch set uploaded (by Paladox):
Set Geshi version in main php file

https://gerrit.wikimedia.org/r/174433

Patch-For-Review

Paladox triaged this task as Medium priority.Dec 5 2014, 5:43 PM
Paladox set Security to None.

Change 174433 merged by jenkins-bot:
Set Geshi version in main php file

https://gerrit.wikimedia.org/r/174433

Krinkle renamed this task from Api problem with SyntaxHighlight to SyntaxHighlight extension version undefined if accessed outside Special:Version.Jan 5 2015, 12:42 PM
Krinkle closed this task as Resolved.
Krinkle assigned this task to Paladox.
Krinkle updated the task description. (Show Details)
Krinkle removed a project: Patch-For-Review.
Krinkle edited subscribers, added: Krinkle; removed: Unknown Object (MLST).

Change 182853 had a related patch set uploaded (by Paladox):
Set Geshi version in main php file

https://gerrit.wikimedia.org/r/182853

Patch-For-Review

Change 182854 had a related patch set uploaded (by Paladox):
Set Geshi version in main php file

https://gerrit.wikimedia.org/r/182854

Patch-For-Review

Change 182854 abandoned by Krinkle:
Set Geshi version in main php file

Reason:
Not a new issue. No need to schedule immediate backporting to production. This will automatically roll out in the deployment train within 1-2 weeks.

https://gerrit.wikimedia.org/r/182854

Change 182853 merged by jenkins-bot:
Set Geshi version in main php file

https://gerrit.wikimedia.org/r/182853