We should get rid of inline styles in LabelElement.
this.$label.css( 'display', !label ? 'none' : '' );
$this->target->setAttributes( !$label ? array( 'style' => 'display: none;' ) : array() );
Trevor Parscal <tparscal@wikimedia.org> wrote:
I think this is dumb, it should be done by removing oo-ui-labeledElement
the same way we do with icons and indicators - and in all 3 cases this
should be done at a higher and more general level. Nonetheless, the
point is if you make the label empty empty empty (see first case from
above) we want to avoid styles being applied to it (probably?).I'm less sure about this case, as you can see, but for compatibility
don't want to change it until we have a cohesive plan.
Version: unspecified
Severity: enhancement