robchur wrote:

OK, deep breath and...what's the problem, again, and what does this solve?

wagnerc wrote:

Problem is easy unix and windows have different end line characters unix like "\n" but windows "\r\n".
I think that wfIsWindows() should be checked if it used for windows detection.

Here is solution for using windows smtp delivered with IIS 5.1.

So the line:
mail( $dest, wfQuotedPrintable( $subject ), $body, $headers );

Should be changed (i.e.):

if(wfIsWindows()) {
mail( $dest, wfQuotedPrintable( $subject ), str_replace( "\n", "\r\n", $body ), str_replace("\n", "\r\n", headers ));
}
else {
mail( $dest, wfQuotedPrintable( $subject ), $body, $headers );
}

robchur wrote:

Changing summary to something that actually makes sense. I assume this is
another one of those "PHP's mail() implementation under Windows is shit" bugs.

wagnerc wrote:

I don't think so that it is Windows, because javax.mail works with the same server
without any special settings, may be it is problem with php or mail() ...

I am not a fan of 'java' but smtp mails works without any change of my lines of code
under JBoss server and IIS mail - same server:)

marco wrote:

(In reply to comment #2)

Problem is easy unix and windows have different end line characters unix like

"\n" but windows "\r\n".

I think that wfIsWindows() should be checked if it used for windows detection.

Here is solution for using windows smtp delivered with IIS 5.1.

So the line:
mail( $dest, wfQuotedPrintable( $subject ), $body, $headers );

Should be changed (i.e.):

if(wfIsWindows()) {
mail( $dest, wfQuotedPrintable( $subject ), str_replace( "\n", "\r\n", $body

), str_replace("\n", "\r\n", headers ));

}
else {
mail( $dest, wfQuotedPrintable( $subject ), $body, $headers );
}

actually it needs a regex to make sure you dont get accidentally \r\r\n on
windows which may cause windows xp prof to crash -.-

robchur wrote:

(In reply to comment #4)

I don't think so that it is Windows, because javax.mail works with the same

server

without any special settings, may be it is problem with php or mail() ...

I am not a fan of 'java' but smtp mails works without any change of my lines

of code

under JBoss server and IIS mail - same server:)

Confirms what I thought. Even Microsoft couldn't get away with that one, could
they? No real need for a regular expression, just replace \r\n with \n, and then
\n with \r\n; the first pass will make sure it's all scooped up nice. Not so
clean, but quick and dirty, just how we like it at MediaWiki HQ. ;)

wagnerc wrote:

Cute clues - the sharp one :) - they impress me

Now I know that it is worth to send some bugs with "very dirty patch" - good job in
the first move and in the second two ...

\n -> \r\n -> security probable
\r\n -> \n -> \r\n -> fastest solution (K.I.S.S.)

I think that is hard is to hack down SMTP with \r\r\r\n (how ugly must be state
machine - this just wait for ".\n" then for "\n") but this know only MS (no open
source code.

Is this still an issue?

EN.WP.ST47 wrote:

This looks like it was a PHP or other upstream bug, that hasn't been confirmed to still exist since October 2008. Since there are no recent reports of problems, closing as presumably fixed.