Page MenuHomePhabricator

redirect sometimes triggers wrong auto-summary
Closed, ResolvedPublic

Description

Author: charlottethewebb

Description:
see diff, should have given an auto-summary of "redirecting to Aberdeen Gardens,
Washington" or something similar instead of "creating new page with..."

charlotte


Version: unspecified
Severity: normal
URL: http://en.wikipedia.org/w/index.php?title=Aberdeen_Gardens&diff=prev&oldid=90414627

Details

Reference
bz8052

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:30 PM
bzimport set Reference to bz8052.
bzimport added a subscriber: Unknown Object (MLST).

rotemliss wrote:

The reason for that is the use of {{subst:PAGENAME}} in the redirection. There
are two possibilities to fix that:

  • Parse {{subst:}} and so before generating the automatic summary (in

Article::doEdit) - possible. The code says that the pre save transform (in
Article::preSaveTransform) is executed immediately after generating the
automatic summary, so it's possible to swap them and do the pre save transform
first.

  • Parse {{subst:}} when creating the automatic summary (in

Article::getRedirectAutosummary or, more likely, in Title::newFromRedirect) - I
don't think it should be done.

  • This bug has been marked as a duplicate of bug 7819 ***