paolo wrote:

The method updateRestrictions in Article.php creates a null edit when a page is
protected. However, the summary does not include the string "[cascading]" even
if the protection is cascading, while this string is included in the logs.

BTW, the summary of paramters lacks the two final params in the same methods.

(In reply to comment #1)

BTW, the summary of paramters lacks the two final params in the same methods.

I am not sure what you mean.

Done in r21512.

paolo wrote:

Thanks for fixing. As for the unclear part, the description of the method is:

/**

• Update the article's restriction field, and leave a log entry. *
• @param array $limit set of restriction keys
• @param string $reason
• @return bool true on success */

But the method prototype contains two more parameters (cascade and expiry):

function updateRestrictions( $limit = array(), $reason = '', $cascade = 0,
$expiry = null )