Page MenuHomePhabricator

SelectCategory: previewing clears the categories
Closed, DeclinedPublic

Description

Author: samuel.gelineau

Description:
When using the SelectCategory extension, clicking the Preview button loads the
preview page, but on this page the SelectCategory select box contains no
selections. As a result, if the user does not notice this and does not reselect
the correct categories, subsequently clicking the Save button will cause the
categories to be lost.


Version: unspecified
Severity: normal
OS: Linux
Platform: PC

Details

Reference
bz9849

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:37 PM
bzimport set Reference to bz9849.
bzimport added a subscriber: Unknown Object (MLST).

samuel.gelineau wrote:

preview_bug.patch

If $_POST["SelectCategoryList"] is defined, this means the categories were
already extracted from the page text in a previous PHP pass. Thus, the
categories listed in this variable should be used. Failing to do so cause the
reextraction to fail, since the first extraction striped the categories from
the page text.

Attached:

slowder wrote:

Although it was commented that the .5 version of selectCategories resolves this issue, the problem remains. I have also compared the function suggested by the patch versus the same function definition found in .5, they are a match. I am still receiving this error. Were there any other changes required to get version .5 to really resolve this issue?

samuel.gelineau wrote:

The stock .5 version works fine on my machine...