Page MenuHomePhabricator

Merge rtl.css into main.css
Closed, ResolvedPublic

Description

Author: lcarsdata

Description:
rtl.css should be merged with main.css for the MonoBook skin.


Version: unspecified
Severity: enhancement

Details

Reference
bz9868

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 9:38 PM
bzimport set Reference to bz9868.
bzimport added a subscriber: Unknown Object (MLST).

lcarsdata wrote:

My bad, this is for all skins.

ayg wrote:

Specifically, RTL <body>s or other areas should have a class like
.mw-rtl/.mw-ltr, or whatever. We can also support [dir=rtl]/[dir=ltr] as being
equivalent, for those browsers that support them.

lcarsdata wrote:

Working on this.

lcarsdata wrote:

Basic patch for monobook

This moves all of the rtl code for monobook into main.css - this works in
Firefox and Opera (with exactly the same bugs as before moving the code) but
not IE6. This code could probably be used if you can figure out where the
rtl.css is added to monobook so an IE if statement can be wrapped around it -
otherwise don't use this patch.

Attached:

ayg wrote:

See also bug 6100. I'm preparing a rather sweeping patch there that aims to fix this too.

RTL override stylesheet SHOULD NOT be merged with any LTR stylesheet at all.

Both environments should not be mixed because of clear distinction and why would the LTR user have to download a bunch of useless stuff -> increases traffic too.

ayg wrote:

Keeping them separate means that LTR-biased developers add stuff to the LTR stylesheet without thinking about the RTL stylesheet. Combining them reduces code duplication, and reduces the number of page requests for RTL wikis. The amount of extra material that needs to be added to the main stylesheets to accommodate RTL, on the other hand, is small.

(In reply to comment #8)

Any progress?

CSS loaded through ResourceLoader is automatically flipped for RTL. Existing rtl.css files need to be audited for any RTL-specific hacks that we need, and those need to be moved to the main CSS files. CC Trevor and Timo for that reason.

*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*

Shouldn't we delete the rtl.css file as it is no longer used?