Page MenuHomePhabricator

Wikibugs does not always report the real name instead of e-mail prefix when reporting on IRC
Closed, ResolvedPublic

Description

If possible, wikibugs should use the real name field instead of the first part of the e-mail address when reporting bug changes. For example, this:

<wikibugs> (mod) Can't link to [[{{FULLPAGENAME}}]] any more - https://bugzilla.wikimedia.org/show_bug.cgi?id=18828 +comment (herd)

would become this:

<wikibugs> (mod) Can't link to [[{{FULLPAGENAME}}]] any more - https://bugzilla.wikimedia.org/show_bug.cgi?id=18828 +comment (Splarka)

Seems much more useful and identifiable to use real names over e-mail address parts.


Version: unspecified
Severity: enhancement

Details

Reference
bz18831

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:40 PM
bzimport set Reference to bz18831.
bzimport added a subscriber: Unknown Object (MLST).

Andrew, wanna take a peek at this some time? :D

Annoyingly, bugzilla doesn't provide this information in a way that's machine-readable without horrible and fragile regexes.

(Batch change)

These are low-priority miniprojects that I can mop up at some point when I'm doing general code work as opposed to working on a specific projects.

thor.malmjursson wrote:

I have posted a similar issue, bug 23159, which if resolved, may very well clear this one up. If someone wants to take a look at that, maybe you can hit 2 bugs in one go. Since the bot uses email prefixes, if we change the login to work as Wiki* would, i.e, assigning a real name or username instead of email as your login, the bot would pick that up instead I believe.

  • Bug 23974 has been marked as a duplicate of this bug. ***

Resolving this bug *might* benefit me the most as I have "admin" as my email prefix. I would therefore be listed as "admin" in MediaWiki-General, which makes me a little weird.

Created attachment 8617
Modify wikibugs to use "real name" instead of e-mail prefix when possible

There's apparently a "X-Bugzilla-Who" header sent with every e-mail, so grabbing just the e-mail address is fairly reliable now. Getting the real name still requires regex hackery, but seems fairly straightforward.

attachment wikibugs-real-names-patch.diff ignored as obsolete

Created attachment 8805
Untested patch to fix the "real name" issue without using so much regex hackery

Re-opening this. The regex currently in use is causing strangeness such as "Brion Vibber <brio". This is broken.

I don't see any reason to try to do fancy lookahead magic here any longer. It was necessary when X-Bugzilla-Who wasn't used/available, but with that, it's much more reliable to try to grab only the real name _or_ use the first part of the e-mail address.

Untested patch against r92606 attached.

Attached:

  • Bug 34506 has been marked as a duplicate of this bug. ***

Fixed with r113013. Pending review / deployment.

deployed / updated on mchenry from latest svn, killed and restarted

This is still happening:

<wikibugs> (NEW) Wikipedia and other site logos pixelated, blurry on high-resolution screens - https://bugzilla.wikimedia.org/35337 normal; Wikimedia: Site logos; (brion)
<wikibugs> (mod) High-density display issues tracking bug (Android hdpi & xhdpi, iPhone Retina display) - https://bugzilla.wikimedia.org/32101 (Brion Vibber)

(In reply to comment #14)

This is still happening:

Adjusting summary.

  • Bug 42504 has been marked as a duplicate of this bug. ***

This is impossible to do without rewriting wikibugs to use a sane API instead of parsing bugmail, as it doesn't include the reporter's full name when a new bug is submitted. (Alternatively, we could hack bugmail to include it.)

(In reply to comment #17)

This is impossible to do without rewriting wikibugs to use a sane API instead
of parsing bugmail, as it doesn't include the reporter's full name when a new
bug is submitted. (Alternatively, we could hack bugmail to include it.)

It fails not only for new bug messages...

<wikibugs> (mod) zh: Missing whitespace between strings for notification of a page change in my watchlist - https://bugzilla.wikimedia.org/47160 +comment (Nemo)
<wikibugs> (mod) zh: Missing whitespace between strings for notification of a page change in my watchlist - https://bugzilla.wikimedia.org/47160 +comment (federicoleva)

(In reply to comment #17)

This is impossible to do without rewriting wikibugs to use a sane API instead
of parsing bugmail, as it doesn't include the reporter's full name when a new
bug is submitted. (Alternatively, we could hack bugmail to include it.)

This is bug 40970, by the way.