Page MenuHomePhabricator

When used as a provider, if a user needs to login, then the extension should redirect to the login form
Closed, ResolvedPublic

Description

Currently, if a user needs to login the provider will redirect to Special:OpenIDServer/Login. This is a form that only accepts a user's password. Rather than doing so, it should redirect to the normal login form Special:UserLogin with a returnto parameter that causes Special:UserLogin to return the user back to the OpenID form.

The reason for this is that the wiki could be using other authentication extensions like OATH, LDAP, or CentralAuth, and they won't exist in the Special:OpenIDServer/Login form.


Version: master
Severity: major

Details

Reference
bz40067

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:09 AM
bzimport set Reference to bz40067.

sumanah wrote:

Tyler, would you be able to take a look at this? Ryan says it's a blocker for using a paste app he'd like to install.

Hello, thanks for the patch.

I will test this - and the code review - as ultra-soon as possible.

Tyler, your proposed fix does unfortunately not work.

It does not make sense, if you supply a patch and cannot test it (you stated in your commit "Unfortunately, I cannot seem to get the OpenID extension working on my test wiki.").

Please let me know how I could help you to get OpenID working on your own test wiki.

I've added an openid project in Labs and created an instance that's pre-installed with mediawiki called openid-wiki. Let's coordinate efforts there. Let me know your labsconsole user names and I'll add both of you to the project.

"OpenID as a provider

As time goes on we want to tie more web service authentication to Labs' LDAP. It would be ideal to make labsconsole an OpenID provider so that services in Labs can use the same authentication source. OpenID as a provider on labsconsole is blocked by bugs 40068 and 40067."

http://www.mediawiki.org/wiki/Wikimedia_Labs/Account_creation_improvement_project

Let's keep the bug open until the change is actually merged in.

The described issue is (for non-wmflabs instances) solved in https://gerrit.wikimedia.org/r/#/c/46198/ .

Ryan; if you discover a new problem, then please file a new bug. the issue you reported with the "OpenID: aborting in ChooseName because identity_url is missing" in the consumer wiki debug log file is a different thing.

Ryan; if you discover a new problem, then please file a new bug. the issue
you > reported with the "OpenID: aborting in ChooseName because identity_url is
missing" in the consumer wiki debug log file is a different thing.

filed now as
https://bugzilla.wikimedia.org/show_bug.cgi?id=44834