Page MenuHomePhabricator

Separate link class for anonymous users
Closed, ResolvedPublic

Description

Right now on Recent changes, links for logged-in users and IP's use the same "mw-userlink" class:

<a class="mw-userlink" title="User:USER123" href="/User:USER123">USER123</a>
<a class="mw-userlink" title="Special:Contributions/12.34.567.89" href="Special:Contributions/12.34.567.89">12.34.567.89</a>

I'm proposing that we give IP's a separate link class so that I can use CSS to make the IP's a different color to stand-out. This would make patrolling edits on Recent changes easier for me and my admins. Something like:

<a class="mw-userlink" title="User:USER123" href="/User:USER123">USER123</a>
<a class="mw-anonlink" title="Special:Contributions/12.34.567.89" href="Special:Contributions/12.34.567.89">12.34.567.89</a>


Version: 1.23.0
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=40072
https://bugzilla.wikimedia.org/show_bug.cgi?id=43362

Details

Reference
bz43179

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 12:50 AM
bzimport set Reference to bz43179.

[ Taking this bug. ]

To maximize coherence, this enhancement should be implemented to the following special pages:

  • [[Special:Contributions]]
  • [[Special:DeletedContributions]]
  • [[Special:RecentChanges]]
  • [[Special:Watchlist]]

It's also to be implemented on pages history.

To avoid to break any stuff relying on current CSS class, the CSS class for anonymous users should be added and not replaced:

<a class="mw-userlink" title="User:USER123" href="/User:USER123">USER123</a>
<a class="mw-userlink mw-anonuserlink" title="Special:Contributions/12.34.567.89"
href="Special:Contributions/12.34.567.89">12.34.567.89</a>

Would that be acceptable?

(In reply to comment #1 by Dereckson)

[ Taking this bug. ]

Dereckson: Do you still plan to work on this?

Note: As this has the 1.21.0 target milestone set, this needs to receive a patch. If this does not receive a patch in the next weeks, the Target Milestone will likely get removed.

Dereckson: Do you still plan to work on this?

Is anyone still working on this? This would make it much easier than the current methods I've been using if($('.mw-userlink').search(/[12]?[\d]{1,2}\.[12]?[\d]{1,2}\.[12]?[\d]{1,2}\.[12]?[\d]{1,2}(\/[1-3]?[\d])?/)){ isIP=true; } which of course only catches IPv4 addresses.

Change 115095 had a related patch set uploaded by Legoktm:
Add 'mw-anonuserlink' class for anonymous users

https://gerrit.wikimedia.org/r/115095

Change 115095 merged by jenkins-bot:
Add 'mw-anonuserlink' class for anonymous users

https://gerrit.wikimedia.org/r/115095