Page MenuHomePhabricator

grrrit-wm should not relay jenkins-bot merges
Closed, DeclinedPublic

Description

Merges by jenkins-bot bear no information: the true information is that someone approved the change. Sure, that everything went well is nice to know, but reviewers/owners/whatever are those who have to check and email notifications take care of that.
Example of redundant info:

10.23 < gerrit-wm> New review: Nikerabbit; "Tested both the old and new editor in couple of cases." [mediawiki/extensions/Translate] (master);

V: 1 C: 2;  - https://gerrit.wikimedia.org/r/54827

10.28 < gerrit-wm> Change merged: jenkins-bot; [mediawiki/extensions/Translate] (master) - https://gerrit.wikimedia.org/r/54827

(Maybe "V: 1 C: 2" is a bit cryptic, but that would be another bug.)


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=35538
https://bugzilla.wikimedia.org/show_bug.cgi?id=46452
https://bugzilla.wikimedia.org/show_bug.cgi?id=46282

Details

Reference
bz46450

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 1:39 AM
bzimport added a project: Gerrit.
bzimport set Reference to bz46450.
bzimport added a subscriber: Unknown Object (MLST).

Merging into bug 46452.

  • This bug has been marked as a duplicate of bug 46452 ***

(In reply to comment #1)

Merging into bug 46452.

Reversed the merge and updated summary: [[wikitech:grrrit-wm]] is the new bot.

It seems this request became controversial, see bug 46452 comment 9, so for now the resolution of bug 46452 means we have basically doubled the traffic on the channel for merges.

jenkins-bot merges are asynchronous, so I think it makes sense to not suppress them.

yuvipanda claimed this task.

Per reason in my last comment.