Page MenuHomePhabricator

VisualEditor: Creating a link while selecting an image modified the link inside the caption
Closed, ResolvedPublic

Description

Steps to reproduce:

1.Open a page with VE
2.Insert a image
3.Open the media settings for the image
4.Insert a link as a caption
5.Save the page
6.Reopen the page and select the image
7.Open the link inspector and type in a different a link inside it
8.Save the page
9.Reopen the page and the Media Settings for the image

Observed Result:
The link inside the caption got changed by the link inserter in step 7

Test Environment: https://test2.wikipedia.org/
Browser: Chrome Version 26.0.1410.65 & FF 25
OS: MAC OS X 10. 8. 5
Page:https://test2.wikipedia.org/w/index.php?title=3rdfebFF&veaction=edit


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=60969
https://bugzilla.wikimedia.org/show_bug.cgi?id=58045

Details

Reference
bz60804

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:51 AM
bzimport set Reference to bz60804.

Created attachment 14472
Screenshot of the error

Attached:

Screen_Shot_2014-02-03_at_6.25.43_PM.png (328×604 px, 186 KB)

If there are multiple links inside the media caption then the link applied outside the image gets applied to all other links .

Change 123429 had a related patch set uploaded by Esanders:
Skip over handlesOwnChildren nodes in newFromAnnotation

https://gerrit.wikimedia.org/r/123429

Change 123429 merged by jenkins-bot:
Skip over handlesOwnChildren nodes in newFromAnnotation

https://gerrit.wikimedia.org/r/123429

Verified the fix in mediawiki.org