Page MenuHomePhabricator

VisualEditor: Disable the redirect input field unless the checkbox is checked
Closed, ResolvedPublic

Description

In the "Page settings" dialog, it says "Redirect this page to" and a blank field for the target name. If you put a name in there, then it sets a redirect, even if you don't tick the checkbox.

VisualEditor should automatically tick the checkbox there if it's going to set a redirect (e.g., as soon as you start typing). Otherwise, it looks like it's not going to redirect the page when you exit the dialog box.

(Reproducing this has only been consistent if there is no redirect on the page at the start of the editing session.)


Version: unspecified
Severity: minor
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=61865

Details

Reference
bz61864

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:51 AM
bzimport set Reference to bz61864.

The logic for this box is meant to work the other way around - that is, you can't set a redirect unless you check the box first - but a simple forgotten line made this not work in one (very frequent) case: when the page isn't a redirect and you're making it one. Whoops. :-(

  • Bug 61866 has been marked as a duplicate of this bug. ***

Change 115237 had a related patch set uploaded by Jforrester:
Disable redirect field unless the checkbox is set in setup

https://gerrit.wikimedia.org/r/115237

Change 115237 merged by jenkins-bot:
Disable redirect field unless the checkbox is set in setup

https://gerrit.wikimedia.org/r/115237