Page MenuHomePhabricator

VisualEditor: [Regression pre-wmf4] All inspector dialog UI is broken when added inside Reference/Media Settings dialog box
Closed, ResolvedPublic

Description

Screenshot

Steps to reproduce:

1.Open a page with VE
2.Open a reference dialog box or Media Settings for an image
3.Try open any of the inspectors:Math/Hiero/Special Character

Observed Result:
All inspector appearing with broken UI

See the screenshot attached

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65
OS: MAC OS X 10. 8. 5


Version: unspecified
Severity: major

Attached:

Screen_Shot_2014-05-02_at_11.26.43_AM.png (447×673 px, 30 KB)

Details

Reference
bz64761

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:08 AM
bzimport set Reference to bz64761.

Change 131112 had a related patch set uploaded by Catrope:
Fix regression in frame style scoping

https://gerrit.wikimedia.org/r/131112

Change 131112 merged by jenkins-bot:
Fix regression in frame style scoping

https://gerrit.wikimedia.org/r/131112

Reopen this issue.
In test2 and beta only.

steps-

1> open the link/math/comment/special characters/ inspectors in Media Settings -> caption sub-editor or the References sub-editor. The inspectors are blank with no UI.

Also see Bug 68130 https://bugzilla.wikimedia.org/show_bug.cgi?id=68130.

Created attachment 17116
screenshot, showing blank link inspector

Attached:

s2.png (458×735 px, 32 KB)

Change 173977 had a related patch set uploaded by Catrope:
Followup ca6a16f: use parent selector both for hiding and showing windows

https://gerrit.wikimedia.org/r/173977

Change 173977 merged by jenkins-bot:
Followup ca6a16f: use parent selector both for hiding and showing windows

https://gerrit.wikimedia.org/r/173977

This bug didn't recur, it was a new bug with a totally different cause. Let's not confuse things by claiming we fixed the same bug. :-)

Ah I see, Sorry we didnt know that before the fix, opening a different one and tagging that against this week's target milestone.

(In reply to Rummana Yasmeen from comment #11)

Ah I see, Sorry we didnt know that before the fix, opening a different one
and tagging that against this week's target milestone.

No worries. :-)