Page MenuHomePhabricator
Create Task
Maniphest T69002

VisualEditor Mobile: Second tap on a reference navigates away from (closes) VE on iOS Safari
Closed, ResolvedPublic
Actions

Description

Author: jgonera

Description:
As mentioned in bug 66999 references require two taps on iOS Safari. Often, the first tap results in a lighter "semi-selection" appearing a bit below the actual reference. When that happens, second tap on the reference suddenly closes the editor (first video).

The editor doesn't crash though, somehow cancel action is triggered. If you have unsaved changes, you'll see a dialog asking you if you want to abandon the edit (second video).

Tested and recorder in iOS Safari 7.1.1. Does not happen on Chrome for Android.

Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=66999
https://bugzilla.wikimedia.org/show_bug.cgi?id=65326

Details

Reference
bz67002

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 3:33 AM
• bzimport added projects: VE-deploy-2014-07-03, VisualEditor-MediaWiki-Mobile.
• bzimport set Reference to bz67002.
• bzimport created this task.Jun 23 2014, 9:38 PM
• bzimport added a comment.Jun 23 2014, 9:38 PM

jgonera wrote:

Editor closes

Attached:

editorclose.mov3 MBDownload

• bzimport added a comment.Jun 23 2014, 9:38 PM

jgonera wrote:

Editor shows confirmation dialog

Attached:

editorclose2.mov5 MBDownload

Jdforrester-WMF added a comment.Jun 24 2014, 1:24 AM

Pushing to Ed because it appears to be a shield/highlight issue.

Jdforrester-WMF added a comment.Jun 26 2014, 6:11 PM

Probably (?) fixed by the fix to bug 67063.

Ryasmeen added a comment.Jun 27 2014, 6:42 PM

This bug did not get fixed by :

Use getClientRects()[0] instead of getBoundingClientRect()

https://gerrit.wikimedia.org/r/142260

Ryasmeen added a comment.Jun 27 2014, 6:58 PM

For images, second tap on it opens up the image which might also be the effect of this same bug.

Ryasmeen added a comment.Jun 28 2014, 12:12 AM

Ok, the behavior got slightly changed here, it wont close the VE now if your second tap on the same reference follows right after your first tap

To reproduce it now you need to first tap on a reference say [1], then tap on another reference [2], then go back and tap [1].Now it will close the VE .

Ryasmeen added a comment.Jun 30 2014, 8:28 PM

This seems to got fixed by:

Select highlights on touchend event

https://gerrit.wikimedia.org/r/142839

Ryasmeen added a comment.Jun 30 2014, 8:28 PM

Verified the fix in Betalabs

Ryasmeen added a comment.Jul 8 2014, 12:23 AM

Verified the fix in test2

Ryasmeen added a comment.Jul 10 2014, 8:20 PM

Verified the fix in production

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 2:00 AM
Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 26 2015, 2:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL