Page MenuHomePhabricator

VisualEditor Mobile: Tapping on a link redirects to the link target page in Safari when the keyboard is hidden
Closed, ResolvedPublic

Description

Steps to reproduce:

1.Open a page with VE that has link inside it.
2.Tap on any link

Observed Result:
The browser page gets redirected to the link target page

Test Environment: https://en.m.wikipedia.org/
Device: iPad Mini


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=66999
https://bugzilla.wikimedia.org/show_bug.cgi?id=67002
https://bugzilla.wikimedia.org/show_bug.cgi?id=67063

Details

Reference
bz65326

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:11 AM
bzimport set Reference to bz65326.

jgonera wrote:

This bug happens on any iOS Safari probably. The link doesn't seem to go to the destination in some cases (in my dev instance it goes to 127.0.0.1 even though I loaded the page from an external IP).

More importantly, this seems to be happening only when the keyboard is hidden (contenteditable is not focused). See attached video.

I tested it on iOS 7.1.1. It doesn't happen on Chrome for Android.

jgonera wrote:

Link is followed (kind of)

Attached:

jgonera wrote:

Jon has never worked on this bug.

Pushing to Ed because it appears to be a shield/highlight issue.

jgonera wrote:

*** Bug 66559 has been marked as a duplicate of this bug. ***

This bug did not resolved by :

FocusableNode: Use getClientRects()[0] instead of getBoundingClientRect()

https://gerrit.wikimedia.org/r/142260

Links don't have any custom highlights (and shields no longer exist) so this must just be a CE bug in iOS (should be filed upstream if possible). We don't even have event listeners on links at the moment but we might have to add some as a work around

(In reply to Ed Sanders from comment #8)

We don't even have event listeners on links at the moment but we might have to
add some as a work around

Eww. If we do, let's keep it as local as possible (mobile-only, for instance).

Change 143152 had a related patch set uploaded by Esanders:
Prevent iOS Safari from following links

https://gerrit.wikimedia.org/r/143152

Change 143152 merged by jenkins-bot:
Prevent iOS Safari from following links

https://gerrit.wikimedia.org/r/143152

Verified the fix in production