Page MenuHomePhabricator
Create Task
Maniphest T71245

rubocop should run after patch set submission to every repo that has Ruby code
Closed, ResolvedPublic
Actions

Description

Bug 63469 implemented basic Ruby syntax check for all repos that have Ruby code.

The next step is to run a linter.

Dan has suggested rubocop[1]. As far as I can see it is the most popular ruby linter[2].

1: https://rubygems.org/gems/rubocop
2: https://www.ruby-toolbox.com/categories/code_metrics

Version: wmf-deployment
Severity: normal
Whiteboard: zfilipin
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=63307
https://rt.wikimedia.org/Ticket/Display.html?id=8103
https://bugzilla.wikimedia.org/show_bug.cgi?id=70605

Details

Reference
bz69245

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:27 AM
• bzimport added a project: Quality-Assurance.
• bzimport set Reference to bz69245.
zeljkofilipin created this task.Aug 7 2014, 3:28 PM
hashar added a comment.Aug 8 2014, 1:54 PM

We need a way to install rubocop. We can probably have it run on labs instance and use gem to install it on job run.

We found out a way to share a gem repository on instances which thus act as a cache preventing to fetch the gem again and again. The snippet is:

  1. Shared cache of gems to avoid hitting rubygems all the time
  2. See https://github.com/bundler/bundler/issues/2856 export GEM_HOME="$WORKSPACE/../gems"

Then gem install.

Ideally, we should have rubocop packaged for Debian and have it installed via puppet. I think ops have some utilities to easily create packages from gems.

gerritbot added a comment.Aug 8 2014, 3:03 PM

Change 152918 had a related patch set uploaded by Zfilipin:
WIP Added builder that runs rubocop, Ruby linter

https://gerrit.wikimedia.org/r/152918

gerritbot added a comment.Aug 8 2014, 3:38 PM

Change 152926 had a related patch set uploaded by Zfilipin:
WIP Run rubocop, Ruby linter, for all repositories that have Ruby code

https://gerrit.wikimedia.org/r/152926

hashar added a comment.Aug 11 2014, 3:14 PM

rubocop will have to be packaged for Debian so we can easily run it. Zeljkof filled https://rt.wikimedia.org/Ticket/Display.html?id=8103

zeljkofilipin added a comment.Sep 2 2014, 12:50 PM

Looks like we will have to install rubocop as a gem somewhere in labs. Waiting for Antoine to get back.

gerritbot added a comment.Oct 10 2014, 1:14 PM

Change 152926 abandoned by Hashar:
Run rubocop, Ruby linter, for all repositories that have Ruby code

Reason:
The continuous integration configuration files are now held in integration/config.git with Zuul layout files being under /zuul/layout.yaml

If there still is an interest in this patch, please port it to the new repository integration/config.git

https://gerrit.wikimedia.org/r/152926

gerritbot added a comment.Oct 14 2014, 12:56 PM

Change 166563 had a related patch set uploaded by Zfilipin:
Added job template and builder that runs rubocop, Ruby linter

https://gerrit.wikimedia.org/r/166563

gerritbot added a comment.Oct 14 2014, 12:57 PM

Change 152918 abandoned by Zfilipin:
Added job template and builder that runs rubocop, Ruby linter

Reason:
Moved to https://gerrit.wikimedia.org/r/#/c/166563/

https://gerrit.wikimedia.org/r/152918

gerritbot added a comment.Oct 15 2014, 3:51 PM

Change 166563 merged by jenkins-bot:
rubocop and lint for all repos having Ruby code

https://gerrit.wikimedia.org/r/166563

gerritbot added a comment.Oct 15 2014, 7:46 PM

Change 166805 had a related patch set uploaded by Hashar:
zuul: move rubocop jobs to experimental

https://gerrit.wikimedia.org/r/166805

gerritbot added a comment.Oct 16 2014, 2:11 PM

Change 166805 merged by Hashar:
zuul: move rubocop jobs to experimental

https://gerrit.wikimedia.org/r/166805

gerritbot added a comment.Oct 20 2014, 1:04 PM

Change 167549 had a related patch set uploaded by Zfilipin:
WIP Move Gemfile and Gemfile.lock to the repository root

https://gerrit.wikimedia.org/r/167549

gerritbot added a comment.Oct 20 2014, 1:08 PM

Change 167566 had a related patch set uploaded by Zfilipin:
WIP run "bundle install" before cd-ing into browser folder

https://gerrit.wikimedia.org/r/167566

gerritbot added a comment.Oct 20 2014, 2:50 PM

Change 167578 had a related patch set uploaded by Zfilipin:
Set up RuboCop

https://gerrit.wikimedia.org/r/167578

gerritbot added a comment.Oct 20 2014, 3:00 PM

Change 167581 had a related patch set uploaded by Zfilipin:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167581

gerritbot added a comment.Oct 20 2014, 3:21 PM

Change 167584 had a related patch set uploaded by Zfilipin:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167584

gerritbot added a comment.Oct 20 2014, 3:38 PM

Change 167589 had a related patch set uploaded by Zfilipin:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167589

gerritbot added a comment.Oct 21 2014, 10:59 AM

Change 167774 had a related patch set uploaded by Zfilipin:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167774

gerritbot added a comment.Oct 21 2014, 11:06 AM

Change 167566 merged by jenkins-bot:
Run "bundle install" before cd-ing into browser folder

https://gerrit.wikimedia.org/r/167566

gerritbot added a comment.Oct 21 2014, 11:10 AM

Change 167777 had a related patch set uploaded by Zfilipin:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167777

gerritbot added a comment.Oct 21 2014, 12:40 PM

Change 167788 had a related patch set uploaded by Zfilipin:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167788

gerritbot added a comment.Oct 21 2014, 1:04 PM

Change 167792 had a related patch set uploaded by Zfilipin:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167792

gerritbot added a comment.Oct 21 2014, 1:13 PM

Change 167794 had a related patch set uploaded by Zfilipin:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167794

gerritbot added a comment.Oct 21 2014, 1:29 PM

Change 167578 merged by jenkins-bot:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167578

gerritbot added a comment.Oct 21 2014, 1:33 PM

Change 167797 had a related patch set uploaded by Zfilipin:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167797

gerritbot added a comment.Oct 21 2014, 1:46 PM

Change 167800 had a related patch set uploaded by Zfilipin:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167800

gerritbot added a comment.Oct 21 2014, 1:50 PM

Change 167801 had a related patch set uploaded by Zfilipin:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167801

gerritbot added a comment.Oct 21 2014, 1:51 PM

Change 167802 had a related patch set uploaded by Hashar:
Enable rubocop on mediawiki/{selenium,ruby/api}

https://gerrit.wikimedia.org/r/167802

gerritbot added a comment.Oct 21 2014, 1:57 PM

Change 167803 had a related patch set uploaded by Zfilipin:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167803

gerritbot added a comment.Oct 21 2014, 2:01 PM

Change 167804 had a related patch set uploaded by Zfilipin:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167804

gerritbot added a comment.Oct 21 2014, 2:04 PM

Change 167805 had a related patch set uploaded by Zfilipin:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167805

gerritbot added a comment.Oct 21 2014, 2:39 PM

Change 167802 merged by jenkins-bot:
Enable rubocop on mediawiki/{selenium,ruby/api}

https://gerrit.wikimedia.org/r/167802

gerritbot added a comment.Oct 21 2014, 2:45 PM

Change 167811 had a related patch set uploaded by Zfilipin:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167811

gerritbot added a comment.Oct 21 2014, 2:49 PM

Change 167813 had a related patch set uploaded by Zfilipin:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167813

gerritbot added a comment.Oct 21 2014, 3:35 PM

Change 167823 had a related patch set uploaded by Zfilipin:
[BrowserTest] Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167823

gerritbot added a comment.Oct 21 2014, 3:40 PM

Change 167824 had a related patch set uploaded by Zfilipin:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167824

gerritbot added a comment.Oct 21 2014, 3:44 PM

Change 167825 had a related patch set uploaded by Zfilipin:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167825

gerritbot added a comment.Oct 21 2014, 3:48 PM

Change 167826 had a related patch set uploaded by Zfilipin:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167826

gerritbot added a comment.Oct 21 2014, 4:24 PM

Change 167823 merged by jenkins-bot:
[BrowserTest] Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167823

gerritbot added a comment.Oct 21 2014, 4:24 PM

Change 167826 merged by jenkins-bot:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167826

gerritbot added a comment.Oct 21 2014, 4:24 PM

Change 167825 merged by jenkins-bot:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167825

gerritbot added a comment.Oct 21 2014, 4:27 PM

Change 167811 merged by jenkins-bot:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167811

gerritbot added a comment.Oct 21 2014, 4:27 PM

Change 167805 merged by jenkins-bot:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167805

gerritbot added a comment.Oct 21 2014, 4:32 PM

Change 167804 merged by jenkins-bot:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167804

gerritbot added a comment.Oct 21 2014, 4:32 PM

Change 167801 merged by jenkins-bot:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167801

gerritbot added a comment.Oct 21 2014, 4:32 PM

Change 167800 merged by jenkins-bot:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167800

gerritbot added a comment.Oct 21 2014, 4:32 PM

Change 167797 merged by jenkins-bot:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167797

gerritbot added a comment.Oct 21 2014, 4:32 PM

Change 167792 merged by jenkins-bot:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167792

gerritbot added a comment.Oct 21 2014, 4:39 PM

Change 167777 merged by jenkins-bot:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167777

gerritbot added a comment.Oct 21 2014, 4:40 PM

Change 167774 merged by jenkins-bot:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167774

gerritbot added a comment.Oct 21 2014, 4:40 PM

Change 167584 merged by jenkins-bot:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167584

gerritbot added a comment.Oct 21 2014, 4:40 PM

Change 167581 merged by jenkins-bot:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167581

gerritbot added a comment.Oct 21 2014, 4:42 PM

Change 167824 merged by jenkins-bot:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167824

gerritbot added a comment.Oct 21 2014, 4:42 PM

Change 167813 merged by jenkins-bot:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167813

gerritbot added a comment.Oct 21 2014, 4:55 PM

Change 167803 merged by jenkins-bot:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167803

gerritbot added a comment.Oct 21 2014, 4:55 PM

Change 167788 merged by jenkins-bot:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167788

gerritbot added a comment.Oct 21 2014, 8:04 PM

Change 167549 merged by jenkins-bot:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167549

gerritbot added a comment.Oct 22 2014, 9:13 AM

Change 168056 had a related patch set uploaded by Zfilipin:
Run RuboCop and Ruby jobs for CentralAuth

https://gerrit.wikimedia.org/r/168056

gerritbot added a comment.Oct 22 2014, 10:00 AM

Change 168056 merged by jenkins-bot:
Run RuboCop and Ruby jobs for CentralAuth

https://gerrit.wikimedia.org/r/168056

gerritbot added a comment.Oct 22 2014, 11:25 AM

Change 168061 had a related patch set uploaded by Zfilipin:
Enable RuboCop jobs for all repositories where it was experimental

https://gerrit.wikimedia.org/r/168061

gerritbot added a comment.Oct 22 2014, 4:38 PM

Change 167589 merged by jenkins-bot:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167589

gerritbot added a comment.Oct 23 2014, 10:08 AM

Change 168264 had a related patch set uploaded by Zfilipin:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/168264

gerritbot added a comment.Oct 23 2014, 10:41 AM

Change 168267 had a related patch set uploaded by Zfilipin:
WIP Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/168267

gerritbot added a comment.Oct 23 2014, 11:03 AM

Change 168270 had a related patch set uploaded by Zfilipin:
WIP Run RuboCop and Ruby syntax check for mediawiki-vagrant

https://gerrit.wikimedia.org/r/168270

gerritbot added a comment.Oct 23 2014, 7:44 PM

Change 168267 merged by jenkins-bot:
tests: Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/168267

gerritbot added a comment.Oct 29 2014, 5:43 PM

Change 168061 merged by Dduvall:
Enable RuboCop jobs for all repositories where it was experimental

https://gerrit.wikimedia.org/r/168061

gerritbot added a comment.Nov 4 2014, 2:55 PM

Change 167794 merged by jenkins-bot:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/167794

gerritbot added a comment.Nov 9 2014, 12:00 AM

Change 168264 merged by jenkins-bot:
Prepare repository for running RuboCop after every push to Gerrit

https://gerrit.wikimedia.org/r/168264

zeljkofilipin added a comment.Nov 20 2014, 1:38 PM

Rubocop is now running. Still not voting. Searching for new repositories with ruby code is reported as a separate bug.

https://phabricator.wikimedia.org/T1332

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL