As mentioned on bug 71454 comment 2 , current travis builds are not loading flickrripper as script_tests cant import dependency ImageTk
https://travis-ci.org/wikimedia/pywikibot-core/jobs/37419168
"flickrripper depends on ImageTk, which isnt available:
No module named ImageTk"
Version: core-(2.0)
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=71454
https://bugzilla.wikimedia.org/show_bug.cgi?id=68606
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T52344 Set up unit test running for pywikibot/core | |||
| Resolved | jayvdb | T71068 split test suite into tests which depend on a server, and those that do not | |||
| Invalid | None | T72936 Important tasks to be solved (tracking) | |||
| Resolved | Xqt | T193968 Missing unittests for scripts (tracking) | |||
| Resolved | Xqt | T71069 Scripts which are not properly tested by script_tests (tracking) | |||
| Resolved | None | T73864 Travis builds not loading flickrripper due to missing ImageTk |
gerritadmin wrote:
Change 170647 had a related patch set uploaded by John Vandenberg:
Script test checks: import ImageTk from PIL
py2.6, py2.7 and py3 builds all have an error when installing Pillow on Travis
https://travis-ci.org/wikimedia/pywikibot-core/jobs/39756966
https://travis-ci.org/wikimedia/pywikibot-core/jobs/39760334
https://travis-ci.org/wikimedia/pywikibot-core/jobs/39756970
which was done here:
https://gerrit.wikimedia.org/r/#/c/159207/
The builds all report the following in the Pillow install routine:
Yet script_tests cant load the module ImageTk. It needs to be loaded as 'from PIL import ImageTk' , but 'import PIL.ImageTk' appears to work for a few versions of Pillow that I have tried.
gerritadmin wrote:
Change 170647 merged by jenkins-bot:
Script test checks: import ImageTk from PIL
After a bit of playing with a brand new install of Python, I can reproduce this.
setup.py test is installing flickrapi into the local directory, and it can be imported within the setup.py environment, ..
/home/travis/build/wikimedia/pywikibot-core/flickrapi-2.0_beta0-py3.3.egg
But, when flickrripper is invoked via pwb.py, flickrapi can not be found.
gerritadmin wrote:
Change 171194 had a related patch set uploaded by John Vandenberg:
Export sys.path to pwb scripts
gerritadmin wrote:
Change 171194 merged by jenkins-bot:
Export sys.path to pwb scripts