API modules should report null-edits as such
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	daniel
	Nov 11 2014, 10:12 AM

Description

Our API modules currently report null-edits as if they actually caused the entity to change (the result contains the new value). API modules could detect null edits by comparing the new revision ID reported by EditEntity (from EntityStore) with the base revision id. If they are the name, the edit did not have any effect. This should be reported by not including a ("new") value in the result, and possibly by providing a special flag ("unchanged" or some such).

Version: unspecified
Severity: normal
Whiteboard: u=dev c=backend p=
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=73257

Details

Reference: bz73258

	Subject	Repo	Branch	Lines +/-
	ResultBuilder: flag null edits with 'nochange'	mediawiki/extensions/Wikibase	master	+22 -5

Customize query in gerrit

Related Objects

Mentioned In: rEWBAc660dc285f27: ResultBuilder: flag null edits with 'nochange'
rMEXT6e620d144ce7: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase…

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:48 AM

• bzimport added a project: MediaWiki-extensions-WikibaseRepository.

• bzimport set Reference to bz73258.

• bzimport added a subscriber: Unknown Object (MLST).

daniel created this task.Nov 11 2014, 10:12 AM

Lydia_Pintscher added a project: Wikidata.Dec 1 2014, 2:35 PM

Lydia_Pintscher removed a subscriber: Unknown Object (MLST).

Ricordisamoa subscribed.Aug 22 2015, 2:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 22 2015, 2:15 PM

The core ApiEditPage sets 'nochange':
https://github.com/wikimedia/mediawiki/blob/9bba2d169ed968839b07c85be487e0185cb38ce0/includes/api/ApiEditPage.php#L533

Ricordisamoa claimed this task.Sep 4 2015, 8:40 PM

Change 236192 had a related patch set uploaded (by Ricordisamoa):
ResultBuilder: flag null edits with 'nochange'

https://gerrit.wikimedia.org/r/236192

gerritbot added a project: Patch-For-Review.Sep 4 2015, 8:42 PM

Change 236192 merged by jenkins-bot:
ResultBuilder: flag null edits with 'nochange'

https://gerrit.wikimedia.org/r/236192

Diffusion mentioned this in rMEXT6e620d144ce7: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Sep 6 2015, 3:09 AM

Ricordisamoa mentioned this in rEWBAc660dc285f27: ResultBuilder: flag null edits with 'nochange'.Sep 6 2015, 3:09 AM

Ricordisamoa removed a project: Patch-For-Review.Sep 6 2015, 3:10 AM

Ricordisamoa set Security to None.

Ricordisamoa removed a subscriber: gerritbot.

Example output before and after the patch:

 {
 	"entity": {
 		"labels": {
 			"en": {
 				"language": "en",
 				"removed": ""
 			}
 		},
 		"id": "Q26",
 		"type": "item",
-		"lastrevid": 1138
+		"lastrevid": 1138,
+		"nochange": ""
 	},
 	"success": 1
 }

Any further actions needed?

Nope, looks good!

Lydia_Pintscher added a project: Wikidata-Sprint-2015-09-01.Sep 7 2015, 11:06 AM

Lydia_Pintscher moved this task from Backlog to Done on the Wikidata-Sprint-2015-09-01 board.

Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Sep 8 2015, 9:36 AM

API modules should report null-edits as suchClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

API modules should report null-edits as such
Closed, ResolvedPublic
Actions